Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metrics): ensure dimension_set is reused across instances (pointer) #1581

Merged
merged 3 commits into from
Oct 10, 2022
Merged

fix(metrics): ensure dimension_set is reused across instances (pointer) #1581

merged 3 commits into from
Oct 10, 2022

Conversation

heitorlessa
Copy link
Contributor

Issue number: #1579

Summary

Changes

Please provide a summary of what's being changed

This PR fixes a bug subsequent instances of Metrics don't reuse aggregated dimensions.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner October 10, 2022 15:52
@heitorlessa heitorlessa requested review from am29d and removed request for a team October 10, 2022 15:52
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 10, 2022
@heitorlessa heitorlessa requested review from leandrodamascena and removed request for am29d October 10, 2022 15:52
@github-actions github-actions bot added the bug Something isn't working label Oct 10, 2022
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2022
@leandrodamascena leandrodamascena linked an issue Oct 10, 2022 that may be closed by this pull request
Bug: Metric.add_dimension doesn't aggregate #1579
Closed
@leandrodamascena leandrodamascena self-assigned this Oct 10, 2022
@heitorlessa heitorlessa changed the title fix(metrics): ensure dimension_set pointer follows class var fix(metrics): ensure dimension_set is reused across instances (pointer) Oct 10, 2022
leandrodamascena
leandrodamascena approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heitorlessa heitorlessa merged commit 7cb937e into aws-powertools:develop Oct 10, 2022
@heitorlessa heitorlessa deleted the fix/metrics-dimension-aggregate branch October 10, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrodamascena leandrodamascena leandrodamascena approved these changes

Assignees

@leandrodamascena leandrodamascena

Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Metric.add_dimension doesn't aggregate
2 participants
@heitorlessa @leandrodamascena