feat(data_classes): case insensitive header lookup #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update BaseProxyEvent `get_header_value` method to be case insensitive by default and add a flag for case sensitive lookups Closes #185
Codecov Report
@@ Coverage Diff @@
## develop #186 +/- ##
========================================
Coverage 98.76% 98.76%
========================================
Files 64 64
Lines 2501 2503 +2
Branches 111 113 +2
========================================
+ Hits 2470 2472 +2
Misses 24 24
Partials 7 7
Continue to review full report at Codecov.
|
heitorlessa
reviewed
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#185
Description of changes:
Update BaseProxyEvent
get_header_valuemethod to be case insensitiveby default and add a flag for case sensitive lookups
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.