Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move from npm to yarn to fix peer deps vuln with resolutions feature #197

Merged
merged 3 commits into from
Oct 23, 2020

Conversation

heitorlessa
Copy link
Contributor

Issue #, if available: #192

Description of changes:

Yarn supports resolutions to force peer dependency versions we don't control to be at a certain version - This in turn generates unmet dependencies so we need to be extra careful.

This PR uses this feature to fix all high and medium security vulnerabilities found that's been pending for the past ~5 months since multiple other packages couldn't update theirs.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@heitorlessa heitorlessa added the internal Maintenance changes label Oct 23, 2020
@heitorlessa heitorlessa merged commit 6a5889b into develop Oct 23, 2020
@heitorlessa heitorlessa deleted the fix/docs-with-yarn branch October 23, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant