feat: Idempotency helper utility #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to-mc
changed the title
added 8 commits
December 16, 2020 15:15
Codecov Report
@@ Coverage Diff @@
## develop #245 +/- ##
===========================================
- Coverage 99.75% 99.23% -0.52%
===========================================
Files 79 85 +6
Lines 2859 3138 +279
Branches 119 151 +32
===========================================
+ Hits 2852 3114 +262
- Misses 5 14 +9
- Partials 2 10 +8
Continue to review full report at Codecov.
|
added 3 commits
January 18, 2021 21:32
added 2 commits
January 19, 2021 17:20
…sistence layer modules
github-actions
bot
added
documentation
nmoutschen
reviewed
Feb 19, 2021
Comment on lines
49
to
56
| **Processes Lambda's event in an idempotent manner** | ||
| >>> from aws_lambda_powertools.utilities.idempotency import idempotent, DynamoDBPersistenceLayer | ||
| >>> | ||
| >>> persistence_store = DynamoDBPersistenceLayer(event_key="body", table_name="idempotency_store") | ||
| >>> | ||
| >>> @idempotent(persistence_store=persistence_store) | ||
| >>> def handler(event, context): | ||
| >>> return {"StatusCode": 200} |
There was a problem hiding this comment.
Question: Should we explain how it'll work under the hood here? This could help clarify how often this will call DynamoDB, what parameters it'll look at to decide if it's an idempotent request or not, etc.
Question: Should we mention how this stores the event into DynamoDB?
There was a problem hiding this comment.
I think if we address this it should be in the documentation. Happy to make changes to the docs based on feedback!
aws_lambda_powertools/utilities/idempotency/persistence/base.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/utilities/idempotency/persistence/base.py
Outdated
Show resolved
Hide resolved
nmoutschen
approved these changes
Feb 19, 2021
added 2 commits
February 19, 2021 15:41
…don't throw the wrong error for INPROGRESS
aws_lambda_powertools/utilities/idempotency/persistence/base.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/utilities/idempotency/persistence/base.py
Outdated
Show resolved
Hide resolved
michaelbrewer
suggested changes
Feb 19, 2021
Co-authored-by: Michael Brewer <michael.brewer@gyft.com>
Co-authored-by: Michael Brewer <michael.brewer@gyft.com>
Co-authored-by: Michael Brewer <michael.brewer@gyft.com>
Co-authored-by: Michael Brewer <michael.brewer@gyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #218
Description of changes:
Implementing RFC #218. I'll be working together with @igorlg on this.
Todos
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.