fix: batch processing exceptions #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to-mc
changed the title
|
Will look into it tomorrow :)
…On Tue, 26 Jan 2021 at 16:46, Tom McCarthy ***@***.***> wrote:
@cakepietoast <https://github.com/cakepietoast> requested your review on:
#276 <#276>
fix: batch processing exceptions.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#276 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBGRLATUQJDBVHUVBZDS33PVNANCNFSM4WTQ7Z2A>
.
|
|
I'm late on reviewing this... I'll try tomorrow evening - Been a roller-coaster these past days |
heitorlessa
requested changes
Feb 2, 2021
|
Implemented requested changes from review |
heitorlessa
added a commit
to nadobando/aws-lambda-powertools-python
that referenced
this pull request
Feb 4, 2021
* develop: chore: bump to 1.10.2 (aws-powertools#282) fix: batch processing exceptions (aws-powertools#276)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #275
Description of changes:
Update batch exception handling to include more detail of the actual exceptions raised in users processing code.
Why not just log the exception one-by-one as we catch them?
By default, the aws_lambda_powertools package logger is suppressed. Logging from package modules would require users to take additional steps to see those logs.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.