Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(general): Add some missing code coverage #296

Merged
merged 9 commits into from Mar 3, 2021

Conversation

michaelbrewer
Copy link
Contributor

Description of changes:

  • test(DictWrapper): Add check for not isinstance
  • test(tracing): Add mock to test aiohttp_trace_config
  • test(appconfig): Add test for get_app_config() without a default provider

Checklist

* test(DictWrapper): Add check for not isinstance
* test(tracing): Add mock to test aiohttp_trace_config
* test(appconfig): Add test for get_app_config() without a default provider
@michaelbrewer michaelbrewer changed the title tests: Add some missing code coverage test(general): Add some missing code coverage Feb 21, 2021
@michaelbrewer
Copy link
Contributor Author

@cakepietoast some more clean up for the next release.

Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One clarification and one tiny change - LGTM after that

tests/functional/test_tracing.py Outdated Show resolved Hide resolved
tests/functional/test_utilities_parameters.py Outdated Show resolved Hide resolved
Michael Brewer and others added 2 commits March 3, 2021 05:55
Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
@codecov-io
Copy link

codecov-io commented Mar 3, 2021

Codecov Report

Merging #296 (c24add9) into develop (6e293b1) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #296      +/-   ##
===========================================
+ Coverage    99.65%   99.87%   +0.21%     
===========================================
  Files           90       90              
  Lines         3217     3217              
  Branches       153      153              
===========================================
+ Hits          3206     3213       +7     
+ Misses           7        2       -5     
+ Partials         4        2       -2     
Impacted Files Coverage Δ
...lambda_powertools/utilities/data_classes/common.py 100.00% <0.00%> (+6.25%) ⬆️
...ambda_powertools/utilities/parameters/appconfig.py 100.00% <0.00%> (+6.89%) ⬆️
aws_lambda_powertools/tracing/extensions.py 100.00% <0.00%> (+75.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e293b1...c24add9. Read the comment docs.

@heitorlessa heitorlessa added the internal Maintenance changes label Mar 3, 2021
@heitorlessa heitorlessa merged commit 4ef565a into aws-powertools:develop Mar 3, 2021
@heitorlessa
Copy link
Contributor

for the record faf75ca 😈

@michaelbrewer michaelbrewer deleted the tests-add-missing branch March 3, 2021 16:00
@heitorlessa heitorlessa added the bug Something isn't working label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants