Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::AppSync::FunctionConfiguration mapping templates packaging support #898

Merged
merged 1 commit into from Jun 12, 2019

Conversation

mkrn
Copy link
Contributor

@mkrn mkrn commented Dec 28, 2018

Add packaging of local files support for "AWS::AppSync::FunctionConfiguration" resource (AWS AppSync Function) mapping templates:

RequestMappingTemplateS3Location
ResponseMappingTemplateS3Location

Issue #, if available:
#897

Description of changes:
Added new AppSync FunctionConfiguration resource and 2 properties to be supported to configuration file along other supported properties.

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfuss
Copy link
Contributor

jfuss commented Dec 28, 2018

@mkrn Thanks for the PR but this is not what you expect. The implementation of package current lives within AWS CLI's package command: https://github.com/aws/aws-cli/blob/develop/awscli/customizations/cloudformation/artifact_exporter.py

What you are editing, is not related to the packing command.

This will be needed to keep references to the correct files with build but that is only after package supports these resources.

@mkrn
Copy link
Contributor Author

mkrn commented Dec 28, 2018

@jfuss Thanks for clarifying this! Now I see, so should that be added anyway and then I can submit another PR to aws-cli ?

@jfuss
Copy link
Contributor

jfuss commented Dec 28, 2018

@mkrn I don't want to accept this until the resources are added within package to avoid confusion.

@mkrn
Copy link
Contributor Author

mkrn commented Dec 28, 2018

@jfuss ok thanks I will update this thread once I submit a PR to aws-cli package

@xentek
Copy link

xentek commented Feb 20, 2019

@thesriram would merging aws/aws-cli#3883 fix this branch?

@sriram-mv
Copy link
Contributor

@xentek
aws/aws-cli#3883 is merged.

…guration" resource (AWS AppSync Function) mapping templates:

RequestMappingTemplateS3Location
ResponseMappingTemplateS3Location
@jfuss jfuss merged commit 98fc370 into aws:develop Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants