feat: allow sam to be invoked as a module #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanathkr
suggested changes
Feb 11, 2019
samcli/cli/main.py
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
Can you instead add a main.py? python -m .. will call the main.py file - https://docs.python.org/3/library/__main__.html
There was a problem hiding this comment.
Moved, this was a good call out.
- python -m samcli.cli.main
- added pylint rule for __main__.py because we dont need to pass ctx to cli, it gets added as part of a decorator. - added docstring
sriram-mv
force-pushed
the
module_exec
branch
from
66311f2
to
836d531
Compare
|
rebasing with develop, hence the force push. |
sanathkr
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python -m samcli.cli.maininvokes sam cliWrite Design Document (Do I need to write a design document?)
Write unit tests
Write/update functional tests
Write/update integration tests
make prpassesWrite documentation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.