Allow specifying of Cloudformation template parameters #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanathkr
reviewed
Sep 20, 2017
| @@ -351,6 +363,24 @@ func main() { | |||
|
|
|||
| } | |||
|
|
|||
| // regexp that parses Cloudformation paramter key-value pair: https://regex101.com/r/hruxlg/3 | |||
| var paramRe = regexp.MustCompile(`(?:ParameterKey)=("(?:\\.|[^"\\]+)*"|(?:\\.|[^, "\\]+)*),(?:ParameterValue)=("(?:\\.|[^"\\]+)*"|(?:\\.|[^ ,"\\]+)*)`) | |||
There was a problem hiding this comment.
Not a big fan of regex. You could have done just a traditional parsing. But this is fine
sanathkr
reviewed
Sep 20, 2017
| . "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| var _ = Describe("Parse Cloudformation parameters", func() { |
sanathkr
reviewed
Sep 20, 2017
sanathkr
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says this enables customers to specify template parameter overrides.
This makes it easy to have the same behavior locally as they would when instantiating their templates with non-default parameter values.
The SAM CLI accepts the same format that AWS CLI does.