Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of calls to source API in getV2ClientNamesRecord #260

Merged
merged 3 commits into from Dec 30, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Dec 30, 2022

Issue

Refs: #251 (comment)

Description

Reduce number of calls to source API in getV2ClientNamesRecord

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2022

🦋 Changeset detected

Latest commit: 8dcbbf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
aws-sdk-js-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trivikr trivikr marked this pull request as ready for review December 30, 2022 04:29
@trivikr trivikr requested a review from a team as a code owner December 30, 2022 04:29
@trivikr trivikr merged commit a1134d4 into main Dec 30, 2022
@trivikr trivikr deleted the perf-get-v2-clients-names-record branch December 30, 2022 04:33
@trivikr
Copy link
Member Author

trivikr commented Dec 30, 2022

Ran transformation on the following code https://github.com/awslabs/aws-sdk-js-codemod/blob/2c8312f84d003a915a3dbafef5e692da544bb0e9/src/transforms/v2-to-v3/__fixtures__/new-client/global-require.input.js
Improvements are not significant, but similar improvements can be done elsewhere.

v0.7.2
$ npx aws-sdk-js-codemod --version
aws-sdk-js-codemod: 0.7.2

jscodeshift: 0.14.0
 - babel: 7.20.7
 - babylon: 7.20.7
 - flow: 0.196.3
 - recast: 0.21.5
 
$ npx aws-sdk-js-codemod -t v2-to-v3 global-require.input.js
Processing 1 files... 
Spawning 1 workers...
Sending 1 files to free worker...
All done. 
Results: 
0 errors
0 unmodified
0 skipped
1 ok
Time elapsed: 12.738seconds
v0.7.3
$ npx aws-sdk-js-codemod --version
aws-sdk-js-codemod: 0.7.3

jscodeshift: 0.14.0
 - babel: 7.20.7
 - babylon: 7.20.7
 - flow: 0.196.3
 - recast: 0.21.5

$ npx aws-sdk-js-codemod -t v2-to-v3 global-require.input.js 
Processing 1 files... 
Spawning 1 workers...
Sending 1 files to free worker...
All done. 
Results: 
0 errors
0 unmodified
0 skipped
1 ok
Time elapsed: 12.289seconds

@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant