Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified logging interface #21

Closed
sapessi opened this issue Apr 12, 2017 · 2 comments
Closed

Unified logging interface #21

sapessi opened this issue Apr 12, 2017 · 2 comments
Assignees
@sapessi
Labels
enhancement
Milestone
Release 0.6

Comments

@sapessi
Copy link
Collaborator

sapessi commented Apr 12, 2017

At the moment the library uses the Lambda Context, where it is available, to access the Logger object. This doesn't scale well and results in "hidden" exceptions in a few places. We should introduce a logger
@sapessi sapessi added this to the Release 0.5 milestone Apr 13, 2017
@sapessi sapessi modified the milestones: Release 0.6, Release 0.5 Jun 20, 2017
@sapessi sapessi mentioned this issue Jul 4, 2017
Closed
sapessi added a commit that referenced this issue Aug 8, 2017
@sapessi
Moved away from Lambda context logger to slf4j-api. This addresses is…
1da7013 
…sues #21. Also removed Lambda context as a dependency from AwsServletContext to address #44.
@sapessi
Copy link
Collaborator Author

sapessi commented Aug 8, 2017

Moved to slf4j-api in the latest commit.

@sapessi sapessi self-assigned this Aug 8, 2017
@sapessi
Copy link
Collaborator Author

sapessi commented Aug 11, 2017

About to merge changes into master, resolving.

@sapessi sapessi closed this as completed Aug 11, 2017
sapessi added a commit that referenced this issue Aug 11, 2017
@sapessi
Removed the last System.out.println to address #21
316a155
@sapessi sapessi mentioned this issue Aug 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sapessi sapessi

Labels
enhancement
Projects
None yet
Milestone
Release 0.6
Development

No branches or pull requests
1 participant
@sapessi