feat(cli): ignore hidden files in "cdk8s init" (#99)

* ignore hidden files in empty directory check * create hidden files for integration tests
cdk8s-team · Apr 10, 2020 · 5681e14 · 5681e14
1 parent a7902d9
commit 5681e14
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/packages/cdk8s-cli/bin/cmds/init.ts b/packages/cdk8s-cli/bin/cmds/init.ts
@@ -20,7 +20,7 @@ class Command implements yargs.CommandModule {
     .choices('TYPE', availableTemplates);
 
   public async handler(argv: any) {
-    if (fs.readdirSync('.').length > 0) {
+    if (fs.readdirSync('.').filter(f => !f.startsWith('.')).length > 0) {
       console.error(`Cannot initialize a project in a non-empty directory`);
       process.exit(1);
     }

diff --git a/test/test-python-app/test.sh b/test/test-python-app/test.sh
@@ -4,6 +4,10 @@ scriptdir=$(cd $(dirname $0) && pwd)
 cd $(mktemp -d)
 mkdir test && cd test
 
+# hidden files should be ignored
+touch .foo
+mkdir .bar
+
 # initialize an empty project
 cdk8s init python-app
 

diff --git a/test/test-typescript-app/test.sh b/test/test-typescript-app/test.sh
@@ -5,6 +5,10 @@ scriptdir=$(cd $(dirname $0) && pwd)
 cd $(mktemp -d)
 mkdir test && cd test
 
+# hidden files should be ignored
+touch .foo
+mkdir .bar
+
 # initialize an empty project
 cdk8s init typescript-app