Fix issue where role updates happened twice #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
==========================================
+ Coverage 93.17% 93.59% +0.41%
==========================================
Files 18 18
Lines 2859 2858 -1
Branches 374 374
==========================================
+ Hits 2664 2675 +11
+ Misses 144 132 -12
Partials 51 51
Continue to review full report at Codecov.
|
stealthycoin
approved these changes
Jul 26, 2017
There weren't any tests for this code path and this didn't break anything, it's just entirely unnecessary. Looks like this was a result of an improper refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There weren't any tests for this code path and this didn't break
anything, it's just entirely unnecessary. Looks like this was a result
of an improper refactoring.