add boolean set method to DJL #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
approved these changes
Mar 25, 2021
stu1130
pushed a commit
that referenced
this pull request
Mar 26, 2021
* add boolean set method to DJL * fix order Change-Id: I3b32bba4878265961c0a64aa05849c394657b9d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Boolean set method for DJL use cases. Also added TF where method.
This PR also introduced the NDArray.intern(): This method aimed to inplace change the reference of NDArray and kill the old reference owner. Typically useful if user would like to reduce object creation in Java.