Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET: null property object support #282

Closed
fulghum opened this issue Oct 24, 2018 · 1 comment
Closed

.NET: null property object support #282

fulghum opened this issue Oct 24, 2018 · 1 comment
Assignees
@eladb
Labels
language/dotnet Related to .NET bindings (C#, F#, ...)

Comments

@fulghum
Copy link

fulghum commented Oct 24, 2018

From @costleya – Requiring code to pass around empty StackProps() param is confusing. This is a bug in the .NET binding generation code.
@fulghum fulghum added the language/dotnet Related to .NET bindings (C#, F#, ...) label Oct 24, 2018
@mpiroc
Copy link
Contributor

mpiroc commented Oct 25, 2018

IIRC this was a bug in the underlying library TypeScript source for some constructors. Check whether this is the case before trying to fix this at the generator level.

@eladb eladb self-assigned this Nov 7, 2018
eladb pushed a commit that referenced this issue Nov 7, 2018
fix(jsii-runtime): treat "null" as "undefined"
a4eb0d2 
Since most languages do not have a distinction between "null" and
"undefined", jsii will effectively convert any "null" value passed into
an argument, a property or inside an object to "undefined".

Adds a compliance test to Java and .NET called "NullShouldBeTreatedAsUndefined".

Fixes aws/aws-cdk#157
Fixes #282
@eladb eladb mentioned this issue Nov 7, 2018
Merged
eladb pushed a commit that referenced this issue Nov 7, 2018
fix(jsii-runtime): treat "null" as "undefined"
d4f8733 
Since most languages do not have a distinction between "null" and
"undefined", jsii will effectively convert any "null" value passed into
an argument, a property or inside an object to "undefined".

Adds a compliance test to Java and .NET called "NullShouldBeTreatedAsUndefined".

Fixes aws/aws-cdk#157
Fixes #282
@eladb eladb closed this as completed in #297 Nov 7, 2018
eladb pushed a commit that referenced this issue Nov 7, 2018
fix(jsii-runtime): treat "null" as "undefined" (#297)
43fb16a 
Since most languages do not have a distinction between "null" and
"undefined", jsii will effectively convert any "null" value passed into
an argument, a property or inside an object to "undefined".

Adds a compliance test to Java and .NET called "NullShouldBeTreatedAsUndefined".

Fixes aws/aws-cdk#157
Fixes #282
@eladb eladb mentioned this issue Nov 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
language/dotnet Related to .NET bindings (C#, F#, ...)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fulghum @eladb @mpiroc