Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET submits invalid Complete callback request #285

Closed
RomainMuller opened this issue Oct 29, 2018 · 1 comment
Closed

.NET submits invalid Complete callback request #285

RomainMuller opened this issue Oct 29, 2018 · 1 comment
Labels
bug This issue is a bug. language/dotnet Related to .NET bindings (C#, F#, ...)

Comments

@RomainMuller
Copy link
Contributor

RomainMuller commented Oct 29, 2018 •
edited
Loading

When submitting Complete requests, the .NET runtime emits error instead of err for failures. This causes the kernel to assume success with undefined value.

Discovered as part of aws/aws-cdk#1027
@RomainMuller RomainMuller added bug This issue is a bug. language/dotnet Related to .NET bindings (C#, F#, ...) labels Oct 29, 2018
@RomainMuller RomainMuller mentioned this issue Oct 29, 2018
Closed
@RomainMuller
Copy link
Contributor Author

I have a fix for this. I'm trying to figure out why the existing compliance tests didn't break with this error (throwing from a callback is part of the tested behavior)

RomainMuller added a commit that referenced this issue Oct 30, 2018
@RomainMuller
fix(dotnet/runtime): Incorrect callback response format
3c2081f 
The response for a callback completion that resulted in an error should use the `err` field
name and not the `error` field name as was initially done. Additionally, the program flow
did not propagate all errors back to the `jsii-kernel`, causing false-pass on the compliance
test suite, as expectations were incorrectly set up to expect `RuntimeException` instead
of `JsiiException`.

Fixes #285
@RomainMuller RomainMuller mentioned this issue Oct 30, 2018
Merged
RomainMuller added a commit that referenced this issue Oct 30, 2018
@RomainMuller
fix(dotnet/runtime): Incorrect callback response format (#286)
1b851e1 
The response for a callback completion that resulted in an error should use the `err` field
name and not the `error` field name as was initially done. Additionally, the program flow
did not propagate all errors back to the `jsii-kernel`, causing false-pass on the compliance
test suite, as expectations were incorrectly set up to expect `RuntimeException` instead
of `JsiiException`.

Fixes #285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. language/dotnet Related to .NET bindings (C#, F#, ...)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RomainMuller