.NET fails mapping objects to interface types when returned from callbacks #290
Assignees
Labels
Comments
RomainMuller
added
bug
RomainMuller
added a commit
that referenced
this issue
Nov 2, 2018
Use the type data available on the deputy object to determine the relevant JSII type for the result of callbacks, instead of trying to map into `PrimitiveType.Any`. Fixes #290 Fixes aws/aws-cdk#1027
RomainMuller
added a commit
that referenced
this issue
Nov 2, 2018
The `jsii` compiler incorrectly mapped types homonym with a standard type (`String`, `Number`, ...) to the primitive type on usage sites. This commit corrects this behavior and adjusts the C# tests accordingly. Additionally, when the return type of a callback was an interface, the C# runtime was unable to determine the correct JSII type to use, despite it has the information on the type of the callback method available. The resolution behavior has also been fixes, as well as a couple of other glitches that became apparent as a result of the `Number` type starting to be correctly represented as the `@scope/jsii-calc-lib.Number` type. Fixes #290 Fixes aws/aws-cdk#1027
RomainMuller
added a commit
that referenced
this issue
Nov 5, 2018
The `jsii` compiler incorrectly mapped types homonym with a standard type (`String`, `Number`, ...) to the primitive type on usage sites. This commit corrects this behavior and adjusts the C# tests accordingly. Additionally, when the return type of a callback was an interface, the C# runtime was unable to determine the correct JSII type to use, despite it has the information on the type of the callback method available. The resolution behavior has also been fixes, as well as a couple of other glitches that became apparent as a result of the `Number` type starting to be correctly represented as the `@scope/jsii-calc-lib.Number` type. Fixes #290 Fixes aws/aws-cdk#1027
RomainMuller
added a commit
that referenced
this issue
Nov 6, 2018
The `jsii` compiler incorrectly mapped types homonym with a standard type (`String`, `Number`, ...) to the primitive type on usage sites. This commit corrects this behavior and adjusts the C# tests accordingly. Additionally, when the return type of a callback was an interface, the C# runtime was unable to determine the correct JSII type to use, despite it has the information on the type of the callback method available. The resolution behavior has also been fixes, as well as a couple of other glitches that became apparent as a result of the `Number` type starting to be correctly represented as the `@scope/jsii-calc-lib.Number` type. Fixes #290 Fixes aws/aws-cdk#1027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a method that is modeled to return an interface type is overridden in .NET, the callback handler fails to map the object to the JSII type, producing the
Could not infer JSII type for .NET typeerror.This is because the callback code attempts to map the type using the
PrimitiveType.Anyreference type instead of what is modeled on the overridden function.This was identified as the root cause of aws/aws-cdk#1027.
The text was updated successfully, but these errors were encountered: