Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel: empty structs should be turned to undefined #411

Closed
RomainMuller opened this issue Mar 28, 2019 · 1 comment
Closed

Kernel: empty structs should be turned to undefined #411

RomainMuller opened this issue Mar 28, 2019 · 1 comment
Assignees
@RomainMuller
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort

Comments

@RomainMuller
Copy link
Contributor

Keyword argument lifting makes it impossible to differentiate an argument not passed from an argument passed with all attributes undefined, hence we need to treat {} as undefined when passing empty structs to the JavaScript code.
@RomainMuller RomainMuller added the bug This issue is a bug. label Mar 28, 2019
@RomainMuller RomainMuller self-assigned this Mar 28, 2019
@RomainMuller
Copy link
Contributor Author

For example, what is in the lambda-cron/index.ts example breaks in Python, because the code cannot possibly trigged the "undefined" props behaviour.

@dstufft dstufft mentioned this issue Mar 28, 2019
Closed
11 tasks
RomainMuller added a commit that referenced this issue Apr 1, 2019
@RomainMuller
feat(kernel): Normalize empty structs to undefined
89ea8b1 
Upon deserializing objects from a "native" front-end (Java, .NET, ...),
the kernel now interprets an empty value for a struct type (aka data
type) as `undefined`, since front-ends that perform keyword lifting such
as Python will not be able to distinguish between "no argument passed"
and "an empty argument passed".

Fixes #411
@RomainMuller RomainMuller mentioned this issue Apr 1, 2019
Merged
RomainMuller added a commit that referenced this issue Apr 2, 2019
@RomainMuller
feat(kernel): Normalize empty structs to undefined (#416)
a8ee954 
Upon deserializing objects from a "native" front-end (Java, .NET, ...),
the kernel now interprets an empty value for a struct type (aka data
type) as `undefined`, since front-ends that perform keyword lifting such
as Python will not be able to distinguish between "no argument passed"
and "an empty argument passed".

Fixes #411
@fulghum fulghum added the effort/small Small work item – less than a day of effort label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomainMuller RomainMuller

Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fulghum @RomainMuller