Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed the version of the JSII that was used to generate an artifact, in the artifact #412

Closed
dstufft opened this issue Mar 28, 2019 · 0 comments · Fixed by #420
Closed

Embed the version of the JSII that was used to generate an artifact, in the artifact #412

dstufft opened this issue Mar 28, 2019 · 0 comments · Fixed by #420
Assignees
@RomainMuller
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved.

Comments

@dstufft
Copy link
Contributor

dstufft commented Mar 28, 2019

When debugging a problem, it's useful to know what version of the JSII it was built with, since that could influence what should have been emitted. At a minimum I would want this done for the Python code, but it's probably good to do for all of them.
@RomainMuller RomainMuller added the feature-request A feature should be added or improved. label Mar 28, 2019
RomainMuller added a commit that referenced this issue Apr 2, 2019
@RomainMuller
feat(jsii): Tag the jsii compiler version in the .jsii assemblies
a2f32ad 
By default, the fully qualified version number (including the commit SHA
prefix) is written in the new `jsiiVersion` field of the assembly,
however in order to make this friendlier to tests, there is an option to
turn over to a *short* format by setting the new `jsii.versionFormat`
key in `package.json` to `'short'`.

Also, slightly altered the generation of the fully qualified version
name to distinguish between cases where the commit SHA was provided by
the CodeBuild environment variable, versus parsed using `git rev-parse`,
denoting the later is indicative of an "unreleased" version.

Fixes #412
@RomainMuller RomainMuller mentioned this issue Apr 2, 2019
Merged
RomainMuller added a commit that referenced this issue Apr 2, 2019
@RomainMuller
feat(jsii): Tag the jsii compiler version in the .jsii assemblies (#420)
42dece1 
By default, the fully qualified version number (including the commit SHA
prefix) is written in the new `jsiiVersion` field of the assembly,
however in order to make this friendlier to tests, there is an option to
turn over to a *short* format by setting the new `jsii.versionFormat`
key in `package.json` to `'short'`.

Also, slightly altered the generation of the fully qualified version
name to distinguish between cases where the commit SHA was provided by
the CodeBuild environment variable, versus parsed using `git rev-parse`,
denoting the later is indicative of an "unreleased" version.

Fixes #412
@RomainMuller RomainMuller self-assigned this Apr 2, 2019
@RomainMuller RomainMuller added the effort/small Small work item – less than a day of effort label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomainMuller RomainMuller

Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(jsii): Tag the jsii compiler version in the .jsii assemblies aws/jsii
2 participants
@dstufft @RomainMuller