Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to Github issues in CONTRIBUTING.md #1149

Merged
merged 1 commit into from Sep 24, 2019
Merged

Fix link to Github issues in CONTRIBUTING.md #1149

merged 1 commit into from Sep 24, 2019

Conversation

kvrhdn
Copy link
Contributor

@kvrhdn kvrhdn commented Sep 21, 2019

Issue #, if available:
N/A

Description of changes:
CONTRIBUTING.md contained a link to an non-existing Github repository. Changed it to this repo.

Description of how you validated changes:
Both links work now.

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #1149 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1149   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files          69       69           
  Lines        3334     3334           
  Branches      651      651           
=======================================
  Hits         3163     3163           
  Misses         89       89           
  Partials       82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff9a5e...21a8be0. Read the comment docs.

@jlhood jlhood changed the base branch from master to develop September 24, 2019 17:15
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@jlhood jlhood merged commit dc96057 into aws:develop Sep 24, 2019
praneetap pushed a commit to praneetap/serverless-application-model that referenced this pull request Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants