Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use "fill" filter with thumbor URLs #190

Closed
carles-codony-manomano opened this issue Feb 25, 2020 · 2 comments
Closed

Unable to use "fill" filter with thumbor URLs #190

carles-codony-manomano opened this issue Feb 25, 2020 · 2 comments

Comments

@carles-codony-manomano
Copy link

When using 'fit-in' or 'upscale' the default behavior is to use the fitting mode 'inside', which maintains the original image's aspect ratio without adding any pixels to the image canvas.

Because of this, the "fill" filter has no effect, since there's no extra image area to be filled.

fit-in urls by default don't use the "inside" fitting mode but "contain", could this be changed?

See examples in the thumbor documentation:
https://github.com/thumbor/thumbor/wiki/Filling

@beomseoklee
Copy link
Member

@carles-codony-manomano thanks for your feedback.
You are right, and we will include this fix to the next release so that "fill" filter can have "contain" fitting mode.

@beomseoklee
Copy link
Member

@carles-codony-manomano
Thanks for waiting, and this issue is fixed in v5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants