Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cache-Control response header #151

Closed
wants to merge 1 commit into from

Conversation

browniebroke
Copy link

The Thumbor version used to have this client side caching, would be nice to have it again.

Relates to #107

Description of changes:

Adding the cache-control header to the response like it used to be before v4

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The Thumbor version used to have this client side caching, would be nice to have it again.
@ericquinones
Copy link

Hi there,
Thank you for the contribution. I can confirm that adding the Cache-Control header is on our list to be evaluated in a future release. Please continue to monitor the repo for updates.

@karensg
Copy link

karensg commented Jan 16, 2020

I definitely think this should be merged.

@beomseoklee
Copy link
Member

Thanks for your effort here, @browniebroke
We have updated our solution, and your pull request has been merged into our master branch. However, as we've merged many pull requests at this time, the source code might not exactly same as what you've done. In addition, due to our internal process, we've merged source code manually, so please understand how your effort has been merged.

You can refer to the recent changes here

@browniebroke browniebroke deleted the cach-control branch February 6, 2020 22:01
@browniebroke browniebroke restored the cach-control branch February 6, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants