Add maven conguration to smithy-build.json #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CR updates SmithyBuildExtensions to use the following smithy-build.json format to allow setting Maven repositories and dependencies.
Existing smithy-build.json files will map
mavenDependency
andmavenRepositories
arrays to the updatedmaven
configuration. Configuration from the newmaven
key will be preferred over anything set in the deprecatedmavenDependency
andmavenRepositories
keys.Deprecation warnings with upgrade instructions are emitted to .smithy.lsp.log when the deprecated keys are encountered in smithy-build.json.
The MavenConfig and MavenRepository classes could eventually be moved to live with the existing SmithyBuildConfig model classes in aws-labs/smithy/smithy-build.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.