Ignore applys #70
Merged
Ignore applys #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new interface was created for getting shape locations, so we can add new methods for getting locations later more easily. Shape location collection was separated into its own class to separate and protect it from `SmithyProject`. The shape location collection was also refactored to get container locations in all files first, then easier to collect member locations. This makes handling multi-file models simpler. There was also a few minor clean ups in `SmithyProject`.
milesziemer
commented
Sep 19, 2022
srchase
reviewed
Sep 20, 2022
src/main/java/software/amazon/smithy/lsp/ext/FileCachingCollector.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/smithy/lsp/ext/ShapeLocationCollector.java
Outdated
Show resolved
Hide resolved
…tor.java Co-authored-by: Chase Coalwell <782571+srchase@users.noreply.github.com>
…ector.java Co-authored-by: Chase Coalwell <782571+srchase@users.noreply.github.com>
srchase
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#68
Description of changes:
applystatements are now ignored by the language server when collecting definition locationsAs mentioned in the issue, the language server was breaking when an apply statement targeted a member mixed in from another namespace. This brought up various issues about how apply statements were being handled, and more generally about how we were collecting shape definition locations. Apply statements could trick the old
collectLocationsmethod into thinking shapes began or ended in arbitrary file locations, or flat out make it crash. At this time,applystatement definition locations don't serve a purpose to the language server, and should be safely ignorable without compromising functionality.Additional changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.