Deserialize empty collections from the query string into None
#1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
|
|
A new doc preview is ready to view. |
crisidev
reviewed
Jan 10, 2022
.../amazon/smithy/rust/codegen/server/smithy/generators/protocol/ServerProtocolTestGenerator.kt
Show resolved
Hide resolved
crisidev
reviewed
Jan 10, 2022
Comment on lines
572
to
584
| // TODO This test does not pass, even after fixing it with this function, because, `NaN` != `NaN`. | ||
| val params = Node.parse("""{ | ||
| "queryFloat": "NaN", | ||
| "queryDouble": "NaN", | ||
| "queryParamsMapOfStringList": { | ||
| "Float": ["NaN"], | ||
| "Double": ["NaN"] | ||
| } | ||
| }""".trimIndent()).asObjectNode().get() | ||
|
|
||
| return testCase.toBuilder().params(params).build() |
There was a problem hiding this comment.
I am not sure why are you doing this if it doesn't work. Is the comment outdated?
There was a problem hiding this comment.
Clarified the comment.
crisidev
reviewed
Jan 10, 2022
.../amazon/smithy/rust/codegen/server/smithy/generators/protocol/ServerProtocolTestGenerator.kt
Show resolved
Hide resolved
crisidev
reviewed
Jan 10, 2022
...n/software/amazon/smithy/rust/codegen/server/smithy/protocols/ServerHttpProtocolGenerator.kt
Show resolved
Hide resolved
crisidev
approved these changes
Jan 10, 2022
|
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
|
We were instead providing empty collections e.g. `Some(Vec::new())`, which makes protocol tests fail. This commit also passes Smithy member names through the symbol provider to obtain safe variable names. This commit also adds some plumbing to the server protocol test case generation to fix broken request test definitions in the `awslabs/smithy` project.
david-perez
force-pushed
the
davidpz-fix-query-string-tests
branch
from
0562e92
to
a42da20
Compare
|
A new generated diff is ready to view.
|
|
A new doc preview is ready to view. |
|
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were instead providing empty collections e.g.
Some(Vec::new()),which makes protocol tests fail.
This commit also passes Smithy member names through the symbol
provider to obtain safe variable names.
This commit also adds some plumbing to the server protocol test case
generation to fix broken request test definitions in the
awslabs/smithyproject.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.