Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discourage users from using hard coded credentials in example code #317

Closed
rcoh opened this issue Apr 20, 2021 · 0 comments · Fixed by #875
Closed

Discourage users from using hard coded credentials in example code #317

rcoh opened this issue Apr 20, 2021 · 0 comments · Fixed by #875
Assignees
@jdisanti
Labels
appsec breaking-change This will require a breaking change good first issue Good for newcomers production-readiness
Milestone
Dev Preview

Comments

@rcoh
Copy link
Collaborator

rcoh commented Apr 20, 2021 •
edited

(eg. in kms-helloworld).

https://github.com/awslabs/smithy-rs/blob/main/aws/rust-runtime/aws-auth/src/lib.rs#L69-L81 (Credentials::from_keys) should also be guarded behind a cargo feature hardcoded-credentials to discourage users from using it
@rcoh rcoh added the appsec label Apr 20, 2021
@jdisanti jdisanti added production-readiness breaking-change This will require a breaking change good first issue Good for newcomers labels Aug 26, 2021
@rcoh rcoh added this to the Dev Preview milestone Sep 27, 2021
@jdisanti jdisanti self-assigned this Nov 19, 2021
@jdisanti jdisanti mentioned this issue Nov 19, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdisanti jdisanti

Labels
appsec breaking-change This will require a breaking change good first issue Good for newcomers production-readiness
Projects
None yet
Milestone
Dev Preview
Development

Successfully merging a pull request may close this issue.

Discourage use of hardcoded credentials smithy-lang/smithy-rs
2 participants
@jdisanti @rcoh