Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing for resolved endpoint #784

Merged
merged 3 commits into from Oct 20, 2021
Merged

Add tracing for resolved endpoint #784

merged 3 commits into from Oct 20, 2021

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Oct 19, 2021

Motivation and Context

It's sometimes useful to see the resolved endpoint URI, signing scope and signing region for debugging.

Description

Add tracing debug event during endpoint resolution

Testing

  • manually verified that a sensible log line is printed:
resolved endpoint endpoint=AwsEndpoint { 
  endpoint: Endpoint { uri: https://ecr-fips.us-east-1.amazonaws.com/, immutable: false }, 
  credential_scope: CredentialScope { region: Some(SigningRegion("us-east-1")), service: None } } base_region=Region("fips-dkr-us-east-1")

Checklist

  • I have updated CHANGELOG.md
  • I have updated aws/SDK_CHANGELOG.md if applicable

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

A new generated diff is ready to view: __generated-main...__generated-log-endpoint

1 similar comment
@github-actions
Copy link

A new generated diff is ready to view: __generated-main...__generated-log-endpoint

@rcoh rcoh requested review from jdisanti and Velfi October 19, 2021 21:02
Copy link
Contributor

@crisidev crisidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rcoh rcoh enabled auto-merge (squash) October 20, 2021 13:25
@github-actions
Copy link

A new generated diff is ready to view: __generated-main...__generated-log-endpoint

@rcoh rcoh merged commit 8f623f6 into main Oct 20, 2021
@rcoh rcoh deleted the log-endpoint branch October 20, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants