Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 Control signing #858

Merged
merged 4 commits into from
Nov 18, 2021
Merged

Fix S3 Control signing #858

merged 4 commits into from
Nov 18, 2021

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Nov 12, 2021

Motivation and Context

This addresses the issue found in awslabs/aws-sdk-rust#291.

Testing

  • Manually ran the S3 Control ListAccessPoints operation to verify it succeeds.
  • Added an integration test for the signing.

Checklist

  • I have updated CHANGELOG.md
  • I have updated aws/SDK_CHANGELOG.md if applicable

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti jdisanti requested a review from a team as a code owner November 12, 2021 21:30
@github-actions
Copy link

A new generated diff is ready to view: __generated-main...__generated-jdisanti-fix-s3-control

2 similar comments
@github-actions
Copy link

A new generated diff is ready to view: __generated-main...__generated-jdisanti-fix-s3-control

@github-actions
Copy link

A new generated diff is ready to view: __generated-main...__generated-jdisanti-fix-s3-control

Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

A new generated diff is ready to view: __generated-main...__generated-jdisanti-fix-s3-control

@github-actions
Copy link

A new generated diff is ready to view: __generated-main...__generated-jdisanti-fix-s3-control

@jdisanti jdisanti merged commit 85abb5b into main Nov 18, 2021
@jdisanti jdisanti deleted the jdisanti-fix-s3-control branch November 18, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants