Relax profile name validation #861
Conversation
|
A new generated diff is ready to view: __generated-main...__generated-jdisanti-fix-profile-name-validation |
2 similar comments
|
A new generated diff is ready to view: __generated-main...__generated-jdisanti-fix-profile-name-validation |
|
A new generated diff is ready to view: __generated-main...__generated-jdisanti-fix-profile-name-validation |
There was a problem hiding this comment.
LGTM! Do you mind adding a test to the default_provider suite (https://github.com/awslabs/smithy-rs/tree/main/aws/rust-runtime/aws-config/test-data/default-provider-chain) that validates this behavior? I just want to be sure that we support this character-set end-to-end (and it's validated). Should be quick since it doesn't need to hit the network
jdisanti
force-pushed
the
jdisanti-fix-profile-name-validation
branch
from
05db31e
to
a0929eb
Compare
|
A new generated diff is ready to view: __generated-main...__generated-jdisanti-fix-profile-name-validation |
| @@ -0,0 +1,9 @@ | |||
| [default] | |||
| region = us-east-1 | |||
| aws_access_key_id = incorrect_key | |||
There was a problem hiding this comment.
👍🏻 good idea to have a default profile as part of the test
Motivation and Context
This addresses awslabs/aws-sdk-rust#270.
Testing
Checklist
CHANGELOG.mdaws/SDK_CHANGELOG.mdif applicableBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.