set appropriate minimum httpbody version #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view: __generated-main...__generated-http-body-version |
1 similar comment
|
A new generated diff is ready to view: __generated-main...__generated-http-body-version |
Velfi
approved these changes
Nov 22, 2021
| http-body = "0.4.0" | ||
| http-body = "0.4.4" |
There was a problem hiding this comment.
do we have to be specific here or could we do "0.4"? Did we ever write down guidelines for how we specify dependency versions?
There was a problem hiding this comment.
we can't do 0.4—we are not compatible with 0.4.0 (that's the entire genesis of this PR)
|
A new generated diff is ready to view: __generated-main...__generated-http-body-version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
awslabs/aws-sdk-rust#305
Description
http_body::combinators was added in 0.4.1 but we specify 0.4.0 in the dependencies.
Testing
Checklist
CHANGELOG.mdif I made changes to the smithy-rs codegen or runtime cratesaws/SDK_CHANGELOG.mdif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.