chore: Add smac to possible install tag, fix comment in example (#766)

syne-tune · Oct 9, 2023 · d98ba99 · d98ba99
1 parent ec7d449
commit d98ba99
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/examples/launch_smac_example.py b/examples/launch_smac_example.py
@@ -83,7 +83,6 @@ def run_smac_simulated_backend():
         dataset=dataset_name,
     )
 
-    # Asynchronous successive halving (ASHA)
     blackbox = trial_backend.blackbox
 
     scheduler = SMAC(

diff --git a/setup.py b/setup.py
@@ -43,7 +43,9 @@ def load_benchmark_requirements():
 required_moo = load_requirements("requirements-moo.txt")
 required_visual = load_requirements("requirements-visual.txt")
 required_sklearn = load_requirements("requirements-sklearn.txt")
+required_smac = load_requirements("requirements-smac.txt")
 
+# Do not add SMAC for now in "extra" as it can easily conflict with Yahpo config-space version
 required_extra = (
     required_gpsearchers
     + required_kde
@@ -95,6 +97,7 @@ def load_benchmark_requirements():
         "bore": required_bore,
         "extra": required_extra,
         "basic": required_basic,
+        "smac": required_smac,
     },
     install_requires=required_core,
     include_package_data=True,

diff --git a/syne_tune/blackbox_repository/conversion_scripts/scripts/requirements-yahpo.txt b/syne_tune/blackbox_repository/conversion_scripts/scripts/requirements-yahpo.txt
@@ -1,3 +1,5 @@
+# TODO uncomment once https://github.com/slds-lmu/yahpo_gym/pull/83 is released in Yahpo
+# onnxruntime>=1.10.0
 onnxruntime==1.10.0
 pyyaml
 configspace<=0.6.1