Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bug in benchmarking where default values were int instead of… #670

Merged
merged 1 commit into from
May 16, 2023

Conversation

mseeger
Copy link
Collaborator

@mseeger mseeger commented May 15, 2023

… bool


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mseeger mseeger requested a review from wesk May 15, 2023 15:17
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.03 ⚠️

Comparison is base (77c2581) 66.03% compared to head (065ce2c) 66.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
- Coverage   66.03%   66.00%   -0.03%     
==========================================
  Files         381      381              
  Lines       26923    26923              
==========================================
- Hits        17778    17771       -7     
- Misses       9145     9152       +7     
Impacted Files Coverage Δ
benchmarking/commons/hpo_main_simulator.py 0.00% <ø> (ø)
...mizer/schedulers/searchers/random_grid_searcher.py 83.64% <0.00%> (ø)
benchmarking/commons/hpo_main_common.py 47.22% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@jgolebiowski jgolebiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@mseeger mseeger merged commit 73efbae into main May 16, 2023
30 checks passed
@mseeger mseeger deleted the fix_benchmark branch May 16, 2023 08:00
wesk added a commit that referenced this pull request May 16, 2023
@wesk wesk added the fix label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants