Add QVBR Portrait Support #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect correct profile.
|
Thanks for the feedback and the detail. We will review the changes and get the update support for portrait videos on to our features road map. |
dscpinheiro
reviewed
Sep 25, 2019
| @@ -38,16 +38,26 @@ exports.handler = async (event) => { | |||
| event[key] = data.Item[key]; | |||
| }); | |||
| let mediaInfo = JSON.parse(event.srcMediainfo); | |||
| event.srcHeight = mediaInfo.video[0].height; | |||
| event.srcWidth = mediaInfo.video[0].width; | |||
| event.rotation = mediaInfo.video[0].rotation; | |||
There was a problem hiding this comment.
Hi @arivera-skycred,
Can you confirm this pull request is up-to-date?
This change you introduced requires the rotation property returned by mediainfo to be included in the event, but that file is not included in this PR.
|
Hi @arivera-skycred, Thanks for your contribution, but for the new version of the solution we just released (v5.0.0 - https://aws.amazon.com/solutions/video-on-demand-on-aws/), we ended up using the approach described on #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#28
Description of changes:
aws-sdkin theencodelambda functionencodelambda function to use theRotateparameterprofilerlambda function to detect the presence ofrotatemetadata and swap dimensions for profile selectionprofilerlambda function to pick the correct profile based on the appropriate dimension based on portrait vs. landscapeTesting
NOTE: this has not been fully tested yet. I have had successful tests using portrait videos that were actually landscape but had the rotation meta data. Looking for help to fully test.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.