Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive search and replace, custom extensions, and a way to replace files #5

Closed
austinkregel opened this issue Dec 11, 2017 · 2 comments

Comments

@austinkregel
Copy link
Contributor

Greetings!

I have been messing around with this codebase a little bit today and have some custom changes I put togeterh. My changes include the following:

  • Add recursive flag option to allow the scan to go more than one directory deep.
  • Add exts option to allow for custom file extensions (adding this will allow for Vue file support)
  • Add an option to replace the files, probably would be used in conjunction with --recursive=true just to make change files much more easy.

My big question is if you would like these changes, and if you would, would you prefer one PR or multiple PRs for these changes.

I merged all my changes onto my master branch, and I tried to keep all other branches as clean as possible in case only a one or two of the changes were desired.

@abdumu
Copy link
Member

abdumu commented Dec 11, 2017

Thanks, I like these ideas.
Separating the PRs is better, so it will be easier to revert in case of any problem.
Also it will be great if you change the README file to include an explanation of these options.

@austinkregel 👏🏼

@austinkregel
Copy link
Contributor Author

Can do 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants