Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use poetry for dependency management #156

Closed
dclimber opened this issue May 27, 2022 · 2 comments · Fixed by #158
Closed

Use poetry for dependency management #156

dclimber opened this issue May 27, 2022 · 2 comments · Fixed by #158

Comments

@dclimber
Copy link
Contributor

Whilst installing dependencies I have stumbled upon the following conflicts:

  1. Python 3.6
    • current Python requirement (>=3.6,<4.0) is not compatible with tortoise-orm's requirement of Python >=3.7,<4.0.
  2. ormar and gino-starlette have conflicting importlib_metadata version requirements.
  3. databases and gino-starlette have conflicting requirements for SQLAlchemy.
  4. pytest >= 7 has conflicting requirements.

My proposal — use poetry for managing dependencies:

  • it automatically resolves issues with dependencies;
  • no need for creating virtual environment manually — poetry creates it for you;
  • there are some other advantages.

Haven't seen any open/closed issues or pull requests on the subject, so opening this ticket.

This was referenced May 27, 2022
@dclimber
Copy link
Contributor Author

Another dependency conflict:

  • gino-starlette (0.1.4) depends on gino (>=1.0.1,<2.0.0)
  • gino (1.0.1) depends on importlib_metadata (>=1.3.0,<2.0.0
  • ormar (0.10.24) depends on importlib-metadata (>=3.1)

Downgrading ormar to 0.9.4 solves the above conflict, but causes this issue, which was resolved in ormar (0.10.24)

@dclimber
Copy link
Contributor Author

dclimber commented May 27, 2022

  1. Downgraded several dependencies, now pytest's tests pass locally on my python 3.8 machine.
  2. Support for python 3.6 had to be removed, due to tortoise-orm 0.17.8 not supporting it.
    • pipelines were also updated — now they are 3.7 and higher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant