Sqlalchemy adaptor error handling issue on "_create"

[tunahan]

Hi, actually there is a need for a small development on _create as well(sqlalchemy.py). When inserting a row via post, I ended up with a different error message. I tried to insert a row into a table that have foreign key constraint on another table. The other table have no primary key value associated with row I tried to insert. So, I violated foreign key constraint.

except IntegrityError: db.rollback() raise HTTPException(422, "Key already exists")

As a result of code above, I get "key already exist". It could be something like that;
except IntegrityError as e: db.rollback() raise HTTPException(422, ", ".join(e.args))

[awtkns]

Hi @tunahan, this is actually working as intended. The idea behind not to show detailed error reports for database errors as I believe giving out details of your database setup to users is generally a bad idea.

However you do raise a fair point. it might be better to change it to simply "Integrity Error" as the message.

[tunahan]

Hi @awtkns, Actually, you are right. The less detailed error stack the better and I agree with that. However, I believe, this level of information should be given. At least you might say "Ohh my friend, at least check the other table". That's it, there is no need for more detail, I believe.

Thanx, I appreciate your work!

[awtkns]

Awesome. Glad we agree. Generally it's a bad idea to give details about internal tables to users as it opens up potential vectors of attack.

I do think that a 500 something error code might make more sense though.