Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make multi-device syncing possible #14

Open
raphaellueckl opened this issue Oct 27, 2020 · 2 comments
Open

Make multi-device syncing possible #14

raphaellueckl opened this issue Oct 27, 2020 · 2 comments

Comments

@raphaellueckl
Copy link
Contributor

For instance, use chrome.storage which could be synced over the network (not the best solution since browser specific) or try anything with WebRTC.

@markus-walther
Copy link
Collaborator

This could perhaps be solved with https://workers.cloudflare.com.

Here is a relevant discussion: https://community.cloudflare.com/t/workers-server-sent-events-server-push/184219.

@markus-walther
Copy link
Collaborator

markus-walther commented Aug 17, 2021

This was merged in a first implementation via PR #36 today. Some aspects warrant a follow-up PR for cleanup and polishing:

  • minified QR-code scanner files make it hard to improve performance there, e.g. to avoid double scanning for normal and inverted QR codes, or fix the bad default algorithm for image binarization, or to finetune how many images are sent to the worker (if native accelerated decoding is not available, e.g. on iOS)
  • debug UI for text sending and connection state should be removed
  • call-to-action button texts should refer to sync task at hand
  • QR code should be page-filling in size, i.e. may need to enlarge overlay
  • WebRTC offer/answer JSONs should be compressed to only their variable parts for slimmer QR codes and uncompressed upon scanning
  • video element only for scanning, QR-code only for generation - not both visible at the same time
  • have a details element in the UI with instructions in German, to explain the sequence of user actions for first-time users
  • fix Uncaught (in promise) DOMException: The play() request was interrupted by a new load request. https://goo.gl/LdLk22
  • fix excessive CPU for long-running QR-code scanning (e.g. timeout for scanner-active)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants