Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken interactions involving manual time entry and Come/Leave buttons #43

Closed
markus-walther opened this issue Jun 7, 2022 · 1 comment · Fixed by #45
Closed
Assignees

Comments

@markus-walther
Copy link
Collaborator

markus-walther commented Jun 7, 2022

Currently, when using between manual time entry and Come/Leave buttons, anomalies occur.

For example, a filled-in time-interval start does not result in the Leave (Gehen) button being activated:
Screen Shot 2022-06-07 at 10 07 58

Also, after a Come/Leave-triggered time pair the Come (Kommen) button looks active, but does not respond to clicks (expected: by opening another time-pair line):
Screen Shot 2022-06-07 at 10 12 28

Third, when adding another time-pair line using the plus button, an empty line is correctly added, but the focus is on the top-of-page time-interval start field. In the same situation, the Come button correctly looks active, but actually clicking it can give varying results, like another time-pair line being appended (expected: reuse the last, empty line) or filling in the time-interval end field and remaining active (expected: Come button only ever fills the start field of a line, Leave button active):
Screen Shot 2022-06-07 at 10 21 37
Screen Shot 2022-06-07 at 10 24 58

Define rigid interaction rules that match user expectations and at least rule out the above anomalies.

Then implement them to fix this issue.

@markus-walther markus-walther self-assigned this Jun 7, 2022
@markus-walther
Copy link
Collaborator Author

Interaction rules:

  1. Come button active iff at least one unfilled time-pair start field exists or no incomplete time-pair line exists.
  2. Leave button active otherwise.
  3. Come button forces appending of a new time-pair line iff 0 time-pair lines or only complete time-pair lines exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant