Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook - some component stories have folder icon #1325

Closed
01231 opened this issue Sep 12, 2019 · 4 comments · Fixed by #1406
Closed

Storybook - some component stories have folder icon #1325

01231 opened this issue Sep 12, 2019 · 4 comments · Fixed by #1406
Assignees
@raphaellueckl
Labels
Bug Low-prio

Comments

@01231
Copy link
Contributor

01231 commented Sep 12, 2019

The icons in the story-tree of AXAButtonLink, AXAButton and AXAInputText differ from the other components. They should all have the same icon.

Bildschirmfoto 2019-09-12 um 08 33 24
@01231 01231 added the Bug label Sep 12, 2019
@danyball
Copy link
Contributor

This is because they are folders. They all have subfolders "React" or "Demo".

@01231
Copy link
Contributor Author

01231 commented Sep 19, 2019

But so does input file.
Bildschirmfoto 2019-09-19 um 14 52 32

@raphaellueckl
Copy link
Contributor

This should be fixed by a team decision on how deep we want our stories to go.

@raphaellueckl
Copy link
Contributor

I asked the storybook devs about this: storybookjs/storybook#8292

@raphaellueckl raphaellueckl self-assigned this Oct 4, 2019
@raphaellueckl raphaellueckl mentioned this issue Oct 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raphaellueckl raphaellueckl

Labels
Bug Low-prio
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix stories wrongly displayed as components axa-ch-webhub-cloud/pattern-library
3 participants
@danyball @raphaellueckl @01231