Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other race gametypes? #28

Closed
axblk opened this issue Jan 10, 2019 · 4 comments
Closed

Support other race gametypes? #28

axblk opened this issue Jan 10, 2019 · 4 comments
Labels
Milestone

Comments

@axblk
Copy link
Owner

axblk commented Jan 10, 2019

Maybe merge (especially team-based) gametypes like DDRace or HpRace.

@axblk axblk added the race label Jan 10, 2019
@axblk axblk mentioned this issue Jan 11, 2019
@Dune-jr
Copy link

Dune-jr commented Jan 11, 2019

Maybe that would be for the best.
If you go with it and design some sort of interface that says IsDDRace(), I can set up a (functional) pull request from https://github.com/axblk/teeworlds/compare/race...Dune-jr:ddr?expand=1

There isn't much work done though, so you might want to work it a completely different way

@axblk
Copy link
Owner Author

axblk commented Jan 14, 2019

I'll add some kind of IsDDRace() check. One important thing is that Race needs a fully functional ninja. There are not too many maps using it but I'd prefer to not break them.
There could also be some problems with the map-settings. DDRace uses some additional options and has other defaults as far as i remember. For now it should be fine to just merge it and set the appropriate defaults in the corresponding game-controller.

@Dune-jr
Copy link

Dune-jr commented Jan 14, 2019

Sounds good.
I foresee no problem with the ninja, the culprit code can easily be encapsulated in a if(IsDDrace()).
In fact, I suspect ninja pickups still work like they would in vanilla on my branch :)

@axblk axblk added this to the Race 4.1 milestone Aug 25, 2019
@axblk
Copy link
Owner Author

axblk commented Jun 16, 2020

Won't fix. This mod concentrates on solo race.

@axblk axblk closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants