Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI breakage in 0.7 due to new kflags member in io_uring_cq #228

Closed
guillemj opened this issue Oct 23, 2020 · 2 comments
Closed

ABI breakage in 0.7 due to new kflags member in io_uring_cq #228

guillemj opened this issue Oct 23, 2020 · 2 comments

Comments

@guillemj
Copy link
Contributor

Hi!

Steinar H. Gunderson has reported in Debian (https://bugs.debian.org/972758) that the 0.7 release broke the ABI in commit 0f05173 when adding the kflags member to struct io_uring_cq. I think at this point the best way forward might be to just quickly release 2.0 and request any downstream to avoid 0.7 and package that instead?

@axboe
Copy link
Owner

axboe commented Oct 23, 2020

Oops yes, that is unfortunate. As 0.7 is 3 months old, it's definitely out there. I guess people just recompiled, I hadn't heard any complaints.

In any case, I don't think we need to be quick on the next release, we're already more than 3 months into this. For 2.0, at least the padding is there for future cases.

@axboe
Copy link
Owner

axboe commented Oct 23, 2020

I hadn't heard any complaints.

Should clarify, before this one :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants