Rematch 5 Support

[e30Birdy]

Since this will be the new version can we get an update that these work together again. Without scripts is like life without coffee

[bloerwald]

Relevant information for us from Gello: https://www.warcraftpets.com/community/forum/viewtopic.php?p=149251&sid=87e17bc5c4b93d1dfbc356c918f00e7d#p149251

They really don't want us to store script information in the team data, but are offering to do API for extending Rematch. I didn't have time to look into it since sadly.

[gizzmo]

So, I've gotten a working edit. It is not backwards compatible, at all (that can be done, but will still leave the file even more messy than it already is)

One major issue though...

In Rematch4 teams are saved with a target ID (number) or a team name (string). As such PBS does the same. On the initial load of Rematch5 those teams are converted to a new format which uses a a unique id (string). It should be possible to convert those over, and have them matchup. Unless if the user been using Rematch5 without PBS, and have made changes to their teams, like myself.

[e30Birdy]

I can't wait to try it out. I have and will never pet battle without this mod. Thanks for all the hard work and dedication

[gizzmo]

I don't mean to take over development on this, but I really wanted to get access to my scripts again. You can see my branch here. I'm sure the update script could use more testing. And maybe making the code backwards compatible (if thats something @axc450 wants)

[fraerie]

So, I've gotten a working edit. It is not backwards compatible, at all (that can be done, but will still leave the file even more messy than it already is)

One major issue though...

In Rematch4 teams are saved with a target ID (number) or a team name (string). As such PBS does the same. On the initial load of Rematch5 those teams are converted to a new format which uses a a unique id (string). It should be possible to convert those over, and have them matchup. Unless if the user been using Rematch5 without PBS, and have made changes to their teams, like myself.

Does this mean you have a version that works with Rematch 5?

[gizzmo]

Does this mean you have a version that works with Rematch 5?

Technically yes it does work with with Rematch5, but there are some carveouts with it, mainly around the script database migration.

• First is it is one way, and will require editing files to go back to Rematch4.
• Same goes for starting over and reimporting from Rematch4, if you were to "reset everything" in Rematch5.
• Next is I've only tested it on my own scripts. So it may still be buggy, so please backup your saved vars. But it seems to have worked well,
• Last and most of all, if you've been using Rematch5 and have made changes to your teams names, or first teams for a target. Scripts will not lineup, and there's no real way to make them.

[fraerie]

Technically yes it does work with with Rematch5, but there are some carveouts with it, mainly around the script database migration.

If I backed up my saved variables and then basically reloaded all the teams does that sound like a good way to approach it?

Also - it that patched version linked here?

Having a crush week at work and a bit brain broken - so being really basic about my assumptions.

[e30Birdy]

Technically yes it does work with with Rematch5, but there are some carveouts with it, mainly around the script database migration.

If I backed up my saved variables and then basically reloaded all the teams does that sound like a good way to approach it?

Also - it that patched version linked here?

Having a crush week at work and a bit brain broken - so being really basic about my assumptions.

You have to change the code yourself from his changes to the file or I am GitHub dumb. They work great though. Had to redo the changes when the mod updated last week.

[gizzmo]

If I backed up my saved variables and then basically reloaded all the teams does that sound like a good way to approach it?

The initial load needs to happen either at the same time, or after Rematch5.

• If you've used Rematch5, do a /rematch reset everything
• Logout and apply my changes
• Log into the game and pray things work.

Also - it that patched version linked here?

You can find my branch Here. Download the Github Zip. Looks like you can copy the contents of the folder that contains the tdBattlePetScript.toc file. The only changes were done to the Rematch folder. You could probably only copy that.

[gizzmo]

Had to redo the changes when the mod updated last week.

Yeah after that version, I did rebase my branch, so its up to date.

[fraerie]

after today's most recent Rematch beta I get the following errors:

1x Interface\FrameXML\Bindings.xml:1 tdBattlePetScript/Rematch/Rematch.xml:1 tdBattlePetScript/Rematch/Rematch.xml(17): error: not well-formed (invalid token)

1x tdBattlePetScript/Rematch/Rematch.xml:1 tdBattlePetScript/Rematch/Rematch.xml(17): error: not well-formed (invalid token)

Line 17 appears to be

[gizzmo]

That's really weird. Not happening for me. Have tried restarting the client? My edit didn't do any change to the Rematch.xml file that would warrant any kind of error. Seems like one of those weird blizzard bugs.

[fraerie]

I'll try restarting in a sec - I disables PBS in the addon list before loading in the first time with the new version of rematch, did a rematch reset everything, turned PBS back on - got that error

I have tried reloading a few times but not restarting the client

[gizzmo]

Uh, if you did a /rematch reset everything you're going to have to reset your tdBattlePetScript.lua SavedVariables file. As the team IDs wont lineup anymore.

Either copy in your backup, or if your comfortable editing the file: delete the ["Rematch"] = { table, and rename the ["Rematch4"] = { to "Rematch"

[fraerie]

I have both restarted the client and deleting the tdBattlePetScript.lua from both the account and character level (I had a back up) and I am still getting the same error

I'm considering clearing out my rematch saved variables too to see what happens

[gizzmo]

With Rematch beta-15, guessing and hoping for matching teams is no longer needed. My branch has been updated to use that.

It should* now reset the scripts back to the Rematch4 backup, if you call /rematch reset everything .
^{(I did have one issue during testing where I lost all my scripts. So PLEASE MAINTAIN BACKUPS)}

[axc450]

Please let me know if we need anything asked/changed on the Rematch end to facilitate this.