-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use image on dockerhub instead of a Dockerfile #1
Comments
Hi, Thanks for the suggestion! I'm pretty new to Docker, that's why I haven't thought about that. Also, I looked into the comments of the PR you linked. From objectbox/objectbox-dart#31 (comment):
@GregorySech You don't have to create this secret by yourself, it is already included by GitHub in the action's context (see https://help.github.com/en/articles/contexts-and-expression-syntax-for-github-actions#github-context). You just have to write it like it is in the README. Also you don't have to run Finally I noticed you run this action twice for two different packages, but in the same job. Maybe I could recommend you to do it in two separate jobs (that you can write in the same workflow file), as each job is run in parallel by GitHub (see https://help.github.com/en/articles/workflow-syntax-for-github-actions#jobs). |
Yes, the version would be fixed to the one you've pushed your image with, however you could even set up your CI (in this project) to update the periodically (e.g. every day) running the action on schedule.
Thanks for that :)
Running the action twice in the same job = trying to avoid building the image twice, though yes, I didn't realize github runs it in parallel so it was actually faster as it originally was. |
Thanks, I'll remove the edit: the key name already matches |
I've made it! Build time has been reduced threefold. |
Changes made! |
Is there any reason the action is set up to build an image each time? It takes 2-3 minutes on each run which could be avoided if the action has used a pre-built image.
from a pipeline:
If I'm not mistaken, this is the line that would need to be changed (besides pushing the image to dockerhub):
https://github.com/axel-op/dart_package_analyzer/blob/stable/action.yml#L21
What do you think?
The text was updated successfully, but these errors were encountered: