-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply inclusion rules for political entities #312
Conversation
d6dbb00
to
bc72643
Compare
Wow! I understand that we'll wait with the (probable) full removal of entities like Mount Athos or the (probable) removal of flag/capital from Bali, for a future analysis of non-island autonomous countries and of non-autonomous islands (as physical entities)?
Do you mean removing more than 5-8 % of the current cards, or on net? If the latter, then we can easily (and sensibly) fill up the gap with islands (as non-political entities) and potentially regions, deserts, lakes, mountain ranges, non-island autonomous regions or even some more seas. :D
On a gut level, I care far more about and are far more likely to ever encounter, in real life, the capitals (and even flags) of Sicily, Corsica, Bali (non-autonomous that it is) or Zanzibar than of, say Jersey (which is among the "marginal" dependent territories likely to get the capital/flag), irrespective of their political status. I would guess that that might hold for many people. That isn't to say that I want the capitals of the former kept, but I'm also not enthusiastic about re-adding (keeping) them for the latter group.
I feel slightly less opposed to including all the dependent territories with maps, for exhaustiveness, though now that I look at them, some are absurdly small (e.g. Pitcairn Islands, pop. < 60)... Hence, my alternative suggestion:
However, I'd also be happy with the full cull. FWIW I haven't yet thoroughly looked at the commit, but on a cursory glance, it looks great implementation-wise! |
bc72643
to
aeee6da
Compare
Ha ! No, I just forgot about them. 😄 I've removed Mount Athos completely and removed Bali's capital and flag for now. I've also changed Bali's capital info to "Island of Indonesia" and updated the numbers in the PR description. |
I did mean net, but only within the political geography side of the deck. Adding more physical geography notes is not going to happen in the short term, so I prefer not to assume too much for now. 😄 Basically, I'm all for removing a bunch of cards, but I don't want it to be a frustrating experience for our users, you know? You make good points about some dependent territories being very small in terms of population. I went back to the spreadsheet to play with the criteria a bit, and try to get more sensible results... I think I managed to keep a bit more notes and a bit more capitals and flags, while not going so far as to include maps for every dependent territory: Here's an overview:
What do you think? |
This is great! Its one disadvantage is obviously that it's more complicated, but I think the thresholds make general sense, and I really like the result! Since the various thresholds will be in the spreadsheet, in the repo, the additional complexity isn't likely to be an issue. |
9d224d8
to
e368a5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I've applied the latest rules as discussed. The new numbers are as follows:
- 41 capitals removed
- 38 flags removed
- 17 maps removed
- 7 maps added
This gives us a net reduction of 133 cards, or 12.0 % of the deck, divided as such:
- 82 capital cards (15.7 % of 524)
- 38 flag cards (14.6 % of 260)
- 10 map cards (3.1 % of 321)
Although this is still significant, I'm happy with the result. I was pretty much saying "well, I won't be missing you" to every piece of content I moved to data-temp.csv
... 😄
Interestingly, most of the political entities that didn't have a capital or a flag to start with -- like Tokelau, Easter Island, or some of the French overseas departments -- are now either fully removed or have had their capital/flag removed. I also removed a bunch of capital hints (e.g. Norfolk Island/Jamaica), which felt very good as well.
I guess the next step would be to have someone else go through the diff to make sure the removals match the spreadsheet and that I didn't forget to remove a hint or something (or removed one by mistake even).
If there are any last-minute objections to the inclusion rules, some entities you think should be brought back in, or removed completely instead of partially, ... or whatever, now is the time!
After that, I think it'll be good to merge this PR (after a bit of tidying, perhaps) so we can keep the temporary folder up to date until we actually release v4.0. There may be changes worth applying to removed entities, notably fixes to the French translation (#293).
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3027d5d
to
094db70
Compare
I've updated |
This comment has been minimized.
This comment has been minimized.
... but keep removed data/sources/media in a new folder named `removed`.
9e8c5b7
to
4e3798e
Compare
Well spotted for Niue and Cook Islands!! 👓 You're totally right about prioritising entity types. I've done as you suggested:
|
I don't see any remaining issues and I don't think we'll catch anything more, (and even if we do, we can just fix it on master), so I'd vote for merging! Apparently even people who are dedicated enough to file issues about the flag of the Northern Mariana Islands don't mind its removal, so I think we're definitely doing "the right thing", even if a 12 % removal is more than what I'd have expected at the very start. |
Yeah, it's reassuring 😄 Alright, let's do this!! 🤘 |
UPDATE - see #312 (comment) and following comments for final inclusion rules and removal stats.
Fixes #306, fixes #221.
Alright, so I've applied the latest inclusion rules discussed in #306. Here's what I've done exactly:
temp
folder insidesrc
with the following:data-temp.csv
- contains the data that moves out of the deck (I followed option D suggested by @aplaice in Upgrade process when data is removed (v4 upgrade) #307 without changing the GUIDs yet) -- note that I've added blank lines to group notes that are removed completely (first group) or only partially (second group).media
folder - contains the media files that move out of the deck.to-be-added.txt
- lists the notes that will need to be added later on to the deck.The new inclusion rules would lead to the removal, in the standard deck, of:
The net result would the removal of 165 cards, or 14.9 % of the 1105 cards currently in the deck.
I have to admit that this is a way more significant cull than I had envisioned, sorry... TBH, I don't think removing more than 5~8 % of the deck is wise.
FWIW, I really like the result for autonomous islands, transcontinental areas and exclaves - i.e. Ceuta, Saba, etc. being removed completely, and Corsica, Sicily, Galápagos Islands, etc. having their capitals and flags removed.
However, I think it would be wiser to rethink the rules for dependent territories. Here is one suggestion:
OR
rule for inclusion with capitals/flags (potentially tweaking the area/population thresholds);AND
rule.I think the above brings some nice benefits (i.e. exhaustiveness, while still removing some of the most obscure capitals and flags), and would not have such a strong impact on the deck.
What are your thoughts?