Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename plane to basis #9

Open
axelpale opened this issue Oct 25, 2022 · 0 comments
Open

Rename plane to basis #9

axelpale opened this issue Oct 25, 2022 · 0 comments
Milestone

Comments

@axelpale
Copy link
Owner

The purpose for plane2 and especially for plane3 is somewhat mixed. While being 2D plane in 3D space, plane3 also provides a reference frame for 3D objects which are not necessarily on the plane. This causes confusion in terminology: the phrase "on the plane" can mean that either the object is on the reference frame spanned by the plane basis OR the object is actually located on the plane.

Furthermore, in various places, for example in projectTo and projectFrom functions, the plane parameter is named as "basis" already.

Therefore it would make sense to either rename "plane" geometries as "basis" or fork "basis" from current plane geometries and drop any notions of basis being a flat surface. This would make the terminology more solid and avoid confusion down the line.

@axelpale axelpale added this to the v3.0 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant