Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in pubsub.asyncIterator() #6

Open
stevesuh opened this issue Oct 3, 2018 · 2 comments
Open

Possible bug in pubsub.asyncIterator() #6

stevesuh opened this issue Oct 3, 2018 · 2 comments

Comments

@stevesuh
Copy link

stevesuh commented Oct 3, 2018

[Node] uncaughtException Error: Failed to create subchannel
[Node]     at Immediate.onConnectionStatus (/Users/ssuh/axio/insurance-storage/node_modules/@google-cloud/pubsub/src/connection-pool.js:293:21)
[Node]     at runCallback (timers.js:697:11)
[Node]     at tryOnImmediate (timers.js:667:5)
[Node]     at processImmediate (timers.js:649:5)

I was logging this line.
https://github.com/axelspringer/graphql-google-pubsub/blob/master/src/google-pubsub.ts#L81

I saw one message go through from the async iterator but then the it blew up on second one. So there should at least be a try catch.

@TimSusa
Copy link
Contributor

TimSusa commented May 20, 2019

We should consider to make the code more resilient here.

@TimSusa
Copy link
Contributor

TimSusa commented May 22, 2019

Another possible problem could be here, that the message is acked before handleMessage. Is that really the way to go, or should ack better be called after handleMessage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants