suggested solution in #73 implemented as pull request

indexeddbshim · May 24, 2014 · e3f08b5 · e3f08b5
1 parent 5fd133b
commit e3f08b5
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 5 deletions.
diff --git a/dist/IndexedDBShim.js b/dist/IndexedDBShim.js
@@ -4,6 +4,22 @@
  * An initialization file that checks for conditions, removes console.log and warn, etc
  */
 var idbModules = {};
+
+var cleanInterface = false;
+(function () {
+    var testObject = {test: true};
+    //Test whether Object.defineProperty really works.
+    if (Object.defineProperty) {
+      try {
+        Object.defineProperty(testObject, 'test',{enumerable:false});
+        if (testObject.test)
+          cleanInterface = true
+      } catch (e) {
+        //Object.defineProperty does not work as intended.
+      }
+    }
+})();
+
 /*jshint globalstrict: true*/
 'use strict';
 (function(idbModules) {
@@ -48,7 +64,7 @@ var idbModules = {};
         this.length = 0;
         this._items = [];
         //Internal functions on the prototype have been made non-enumerable below.
-        if (Object.defineProperty) {
+        if (cleanInterface) {
             Object.defineProperty(this, '_items', {
                 enumerable: false
             });
@@ -87,7 +103,7 @@ var idbModules = {};
             }
         }
     };
-    if (Object.defineProperty) {
+    if (cleanInterface) {
         for (var i in {
             'indexOf': false,
             'push': false,

diff --git a/src/Init.js b/src/Init.js
@@ -3,4 +3,19 @@
 /**
  * An initialization file that checks for conditions, removes console.log and warn, etc
  */
-var idbModules = {};
+var idbModules = {};
+
+var cleanInterface = false;
+(function () {
+    var testObject = {test: true};
+    //Test whether Object.defineProperty really works.
+    if (Object.defineProperty) {
+      try {
+        Object.defineProperty(testObject, 'test',{enumerable:false});
+        if (testObject.test)
+          cleanInterface = true
+      } catch (e) {
+        //Object.defineProperty does not work as intended.
+      }
+    }
+})();
diff --git a/src/util.js b/src/util.js
@@ -42,7 +42,7 @@
         this.length = 0;
         this._items = [];
         //Internal functions on the prototype have been made non-enumerable below.
-        if (Object.defineProperty) {
+        if (cleanInterface) {
             Object.defineProperty(this, '_items', {
                 enumerable: false
             });
@@ -81,7 +81,7 @@
             }
         }
     };
-    if (Object.defineProperty) {
+    if (cleanInterface) {
         for (var i in {
             'indexOf': false,
             'push': false,