New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DX-196; use axiom ingest endpoints #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
schehata
commented
Sep 19, 2022
•
edited by bahlo
edited by bahlo
- Separate vercel, netlify and generic config handlers
- ensure all variables work with vercel deployments
- ensure all variables work with netlify deployments
- find a way to pass auth through navigator.beacon (didn't work, beacon will only be used with verbal for now)
- review namings and code structure
- update README/docs for vercel and non-vercel usage
- compare verbal schema before and after change
- send web vitals one by one on non-vercel platforms
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
schehata
force-pushed
the
without-vercel
branch
from
September 19, 2022 10:31
54b69f9
to
3690940
Compare
schehata
force-pushed
the
without-vercel
branch
from
September 19, 2022 13:42
a341f5d
to
48cc545
Compare
schehata
force-pushed
the
without-vercel
branch
from
September 19, 2022 14:01
39bb956
to
5f2274c
Compare
schehata
force-pushed
the
without-vercel
branch
from
September 20, 2022 11:06
e6c1c15
to
067ab58
Compare
schehata
force-pushed
the
without-vercel
branch
from
September 28, 2022 06:57
8712d98
to
ccc8cb8
Compare
schehata
force-pushed
the
without-vercel
branch
from
November 25, 2022 16:45
69c1b88
to
7735a75
Compare
this is an example of webVital request on netlify platform, I think its missing the request object, but probably this is usually generated by the proxy? {
"netlify": {
"buildId": "6380f7b1da05a646c54a4b5c",
"context": "production",
"environment": "production",
"source": "web-vital"
},
"webVital": {
"id": "v2-1669396643686-4218206098399",
"label": "web-vital",
"name": "TTFB",
"route": "/",
"startTime": 0,
"value": 476.00000000000006
}
} |
bahlo
reviewed
Nov 28, 2022
schehata
force-pushed
the
without-vercel
branch
from
November 28, 2022 13:56
206e429
to
ec5ecc7
Compare
bahlo
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work, let's do this 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.