Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support collecting logs outside of spans #12

Open
geekflyer opened this issue Oct 16, 2023 · 3 comments
Open

Support collecting logs outside of spans #12

geekflyer opened this issue Oct 16, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@geekflyer
Copy link

geekflyer commented Oct 16, 2023

Hi,

just came across this library in search how to best integrate logs+traces from a Rust app into axiom.
One of the stated limitations in the README is that this library does not support collecting logs outside of spans - presumably because it only supports the otel trace protocol.

Anyways - I'd suggest to have a look at integrating https://github.com/open-telemetry/opentelemetry-rust/tree/main/opentelemetry-appender-tracing which in my understanding would allow collecting tracing events that are emitted from outside a span.

@darach
Copy link
Contributor

darach commented Oct 20, 2023

Hi Christian @geekflyer ,

Thank you for the suggestion, we'll take a look and see what we can do.

Cheers,

Darach.

@darach darach added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Dec 1, 2023
@darach
Copy link
Contributor

darach commented Dec 1, 2023

Hi Christian @geekflyer,

I had a look into this yesterday and this morning. The release of v0.21 of opentelemetry-rust is not binary compatible with v0.20 that we depend upon. But, once we schedule that work its a good enhancement, so i've labelled it as such.

Thank you for suggesting the enhancement 👍. Let us know if this is something you'd be interesting in working on and contributing! 🤩

Cheers,

Darach.

@cherryman
Copy link

@darach I've only taken a brief glance at the code, but it seems that using axiom's api directly instead of going through opentelemetry should make this easy to support. Send all tracing events as axiom events and let axiom work out which ones correspond to a trace. This would also remove otel from the dep tree. As an example, see the code for tracing-honeycomb which takes this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants