Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs regarding cancellation #57

Closed
19shubham11 opened this issue Nov 26, 2021 · 2 comments
Closed

Update docs regarding cancellation #57

19shubham11 opened this issue Nov 26, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@19shubham11
Copy link

I was searching about cancellable requests and was a bit confused about the existing docs here -> https://axios-http.com/docs/cancellation as they only talked about cancellable promises and I wanted to use AbortController

Turns out, AbortController is of course supported since this PR was merged, but I had to dig a bit deep into the code to find that 😅

Maybe the docs should reflect the support for AbortController and reference to the relevant JS API ref for that!
@19shubham11 19shubham11 added the enhancement New feature or request label Nov 26, 2021
@jasonsaayman
Copy link
Member

Cool thanks, I will have to start being more insistent on docs being updated when support is added.

@jasonsaayman
Copy link
Member

Done with #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonsaayman @19shubham11